Details
-
Type:
Improvement
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Won't Fix
-
Affects Version/s: 4.1.0
-
Fix Version/s: 4.4.0
-
Component/s: Core CiviCRM
-
Labels:None
Description
I noticed that when uploading a user photo, CiviCRM is returning the full-size image and relying on the browser to resize it to a thumbnail.
The first patch allows the use of the Drupal image_resize() function if it is available.
The second patch corrects CRM_Contact_BAO_Contact::getThumbSize() so that the returned width is an integer rather than a float.
Attachments
Activity
Also need to change the template to use the thumbnail URL...
Punting to 4.1 for a few reasons:
1. Not sure if relying on the browser is a bad thing? How does HTML5 play into this?
2. Ideally we'd want to do this for both drupal and joomla rather than only drupal. Might make sense to "relocate" drupal's code to within civicrm and use it for both
1. If the user uploads a large-size photo, handing it to the browser for resizing may waste several hundred kilobytes of bandwidth.
2. A better way would to implement a UF_resize_image() wrapper and define it within drupal/civicrm.module and joomla/site/civicrm.php respectively.
If I get a chance to work on it, I'll post a patch here, as usual.
It turns out that Joomla doesn't have a core function to resize images, so code duplication is probably necessary.
Closing issues in batch on 4/16/13 since these issues have not been worked on in a long long time
More image-resizing code. Should probably factor it out into a function but I don't know which file should hold the function.