Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8006

UpdateAddress.php considers a 'null' geocode succesful

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.3.6, 3.4.0, 4.0.0
    • Fix Version/s: 3.4.1
    • Component/s: None
    • Labels:
      None

      Description

      At line #152 of CRM/Utils/Geocode/Google.php we see:

      // reset the geo code values if we did not get any good values
      $values['geo_code_1'] = $values['geo_code_2'] = 'null';
      return false;

      which line #209 of bin/UpdateAddress.php considers successful:

      if ( isset( $params['geo_code_1'] ) ) {
      $totalGeocoded++;

      Patch simply adds check for 'null' as return value.

      This issue may be addressed as part of CRM-7699

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              fen Fen Labalme
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: