Details
-
Type: Bug
-
Status: Done/Fixed
-
Priority: Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 3.3.6, 3.4.0, 3.4.1, 4.0.0, 4.0.1
-
Fix Version/s: 4.0.2
-
Component/s: Core CiviCRM
-
Labels:None
Description
A number of form templates do not use the required top and bottom location parameters when including 2 instances of CRM/common/formButtons.tpl. This results in 2 form elements (buttons) with the same "id" on the page - which is invalid HTML and can cause problems for developers wanting to use CSS to modify page layout.
I did a grep on all templates containing this pattern
{include file="CRM/common/formButtons.tpl"}- which excludes the location parameter. Then corrected all files which have 2 instances of this pattern so that one instance is :
{include file="CRM/common/formButtons.tpl" location="top"}and the 2nd instance is:
{include file="CRM/common/formButtons.tpl" location="bottom"}– Original Post —
templates/CRM/Contact/Page/View/Note.tpl
line 64
button location should be "top"
currently we have the location "bottom" duplicated, which duplicates css id values