Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.1
    • Fix Version/s: 3.4.3
    • Component/s: CiviContribute
    • Labels:
      None

      Description

      In r12700, the signature of CRM_Core_Payment_BaseIPN::loadObjects was changed (by adding a new parameter, $required). However, one of its consumers (CRM_Core_Payment_GoogleIPN::orderStateChange) was not updated to use the revised signature, so any requests which hit this will create PHP warnings.

      It looks like r12700 enabled a new, alternative mode of execution – when $required=false, a new behavior would be used; when $required=true, an old behavior would be used. I'm not certain which is appropriate for GoogleIPN, but – based on general refactoring practices – it seems appropriate to set $required=true by default.

        Attachments

          Activity

            People

            • Assignee:
              deepak Deepak Srivastava
              Reporter:
              timotten Tim Otten
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: