CRM-8371 Drush fails all commands with CiviCRM findable and php 5.3.x

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.0.4
    • Fix Version/s: 3.4.5, 4.0.5
    • Labels:
      None

      Description

      With php 5.3.x (current Ubuntu Natty version), you can't run drush against a site that has civicrm in the file system. Drush errors with:

      Deprecated function: Assigning the return value of new by reference [error]
      is deprecated in _drush_add_commandfiles() (line 941 of
      /usr/share/drush/includes/command.inc).

      Note civi doesn't even need to be installed. This error is occuring b/c the drush include file uses the (unneeded) php 4 method of assigning new by reference:
      $someobj =& new SomeClass();

      This hasn't been necessary since PHP 5 came out. Since Civi requires php 5 we can safely fix these.

        Attachments

          Activity

          [CRM-8371] Drush fails all commands with CiviCRM findable and php 5.3.x
          Jamie McClelland added a comment -

          I think this patch was not properly merged to the 4.0 branch. I hit the same bug while running the latest 4.0 branch.

          Jamie McClelland added a comment -

          Sorry - ignore that last comment. my mistake - it is properly merged.

            People

            • Assignee:
              Neha Kulkarni
              Reporter:
              Matt Moen

              Dates

              • Created:
                Updated:
                Resolved: