Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8599

Untested var causes a non-blocking error when disabling wordreplacements

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.0.4
    • Fix Version/s: 3.4.5
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      Configure a set of word replacement.
      Disable them and validate, a notice appears :
      """
      Notice : Undefined index: cb dans CRM_Admin_Form_WordReplacements->postProcess() (ligne 209 dans /var/www/drupal/sites/all/modules/civicrm/CRM/Admin/Form/WordReplacements.php).
      """

      In /var/www/drupal/sites/all/modules/civicrm/CRM/Admin/Form/WordReplacements.php, the is_array function is used on the $params['cb'] var, but it seems that in this case $params doesn't provide the cb key, the following patch adds a little isset test in the if block.

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              tonthon tonthon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 15 minutes
                15m
                Remaining:
                Remaining Estimate - 15 minutes
                15m
                Logged:
                Time Spent - Not Specified
                Not Specified