Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8648

code cruft looks like it can go

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.5, 4.0.5
    • Fix Version/s: 4.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Was poking around in sync code & the lines below look like they are legacy handling for when 'domain_id' was intro'd to uf_match table

      Index: CRM/Core/BAO/UFMatch.php
      ===================================================================
      — CRM/Core/BAO/UFMatch.php (revision 35675)
      +++ CRM/Core/BAO/UFMatch.php (working copy)
      @@ -229,11 +229,7 @@

      // make sure that a contact id exists for this user id
      $ufmatch = new CRM_Core_DAO_UFMatch( );

      • if ( CRM_Core_DAO::checkFieldExists('civicrm_uf_match', 'domain_id') ) { - // FIXME: if() condition check was required especially for upgrade cases (2.2.x -> 3.0.x), - // where folks if happen to logout, would encounter a column not found fatal error - $ufmatch->domain_id = CRM_Core_Config::domainID( ); - }

        +
        $ufmatch->uf_id = $userKey;
        if ( ! $ufmatch->find( true ) ) {
        require_once 'CRM/Core/Transaction.php';

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: