CRM-8825 Date range label From: isn't translated and isn't available for translation

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Won't Fix
    • Affects Version/s: 4.0.5
    • Fix Version/s: 3.4.6
    • Component/s: Internationalisation
    • Labels:
      None

      Description

      In french, for example when going to the report ListingPaticipantCount, date ranges' labels are : From: and Et: (the first in english and the second in french)
      No ts func is used around the $label argument from the addDateRange function
      Adding it solves the issue.
      See attached patch

        Attachments

          Activity

          [CRM-8825] Date range label From: isn't translated and isn't available for translation
          Donald A. Lobo added a comment -

          I dont think this patch is correct. We dont translate variables (since we cant add them to the translation database). The ts function should be placed in the calling functions.

          Can u check and resubmit the patch

          tonthon added a comment -

          Maybe translating the default value will be a better solution (but it's not possible in the function definition)

          Donald A. Lobo added a comment -


          We should find and fix the callers for this issue. Lets file a separate issue for those when we trip against them

            People

            • Assignee:
              Donald A. Lobo
              Reporter:
              tonthon

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 15 minutes
                15m
                Remaining:
                Remaining Estimate - 15 minutes
                15m
                Logged:
                Time Spent - Not Specified
                Not Specified