Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-9052

Cancel date not set to today when left empty (CRM_Utils_System::isNull needs to handle 'null' string as a null value)

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.6
    • Fix Version/s: 4.1.0
    • Component/s: CiviContribute
    • Labels:
      None

      Description

      When cancelling an existing contribution, the Cancel Date is supposed to be set to TODAY if no value is selected from the date picker. This happens because the form passes 'null' string, but postProcess uses CRM_Utils_System::isNull to see if the form value is empty.

      I've added a hack to isNull () to also check for 'null' string. We should remove that when we have DAO code that can pass null values to a DB column w/o passing 'null'.

        Attachments

          Activity

            People

            • Assignee:
              dgg David Greenberg
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: