CRM-9779 Common payment notification framework for payment processor extensions

I think this patch is not correct. The query that gets the processor id is doing a wrong JOIN, that gets processor id as null if the name set in the Processor table it's different than the Processor Type name

SELECT ppt.class_name, ppt.name as processor_name, pp.id AS processor_id
FROM civicrm_payment_processor_type ppt
LEFT JOIN civicrm_payment_processor pp
----> ON pp.name = ppt.name <------------
AND pp.is_active
AND pp.is_test = %1
WHERE ppt.name = %2

should be

ON pp.payment_processor_type = ppt.name

Thanks for the heads-up. The query was fixed in a later commit to trunk. Check out lines 216 to 223 in latest revision: 40825 - of CRM/Core/Payment.php.

More specifically, this should have been fixed as part of CRM-9929.

In its current state, this patch worked only if the Payment Processor instance and the Payment Processor type shared the same name.

Minor SQL fix. Corrected join is

ON pp.payment_processor_type = ppt.name

rather than

ON pp.name = ppt.name

Argh, Luciano spotted that above. Sorry for re-opening.

As per comment.