CRM-9941 PCP amount raised incorrectly formatted in views intergration

I'm at the code sprint in San Francisco and would like to take a look at this. Could you export the view and add it to the issue so I can reproduce the problem? Thanks!

Per Kurund's suggestion, I created a new handler for monetary formats. Views will now use CiviCRM's internal formatting logic rather than require site admins to piece the display together using the various components. I updated the integrations for Contribute, Campaign, and Event so that all fields pertaining to monetary amount use the new handler. Additionally, I cleaned up the civicrm_handler_field_pcp_raised_amount code a bit. This handler now too outputs a formatted monetary string.

Do you still need the export?

$view = new view;
$view->name = 'personal_campaign_pages';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'civicrm_pcp';
$view->human_name = 'Personal Campaign pages';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'Sponsor a Walker';
$handler->display->display_options['css_class'] = 'sponsor_walker';
$handler->display->display_options['use_more'] = TRUE;
$handler->display->display_options['use_more_always'] = TRUE;
$handler->display->display_options['use_more_text'] = 'View more walkers to sponsor';
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['query']['options']['query_comment'] = FALSE;
$handler->display->display_options['exposed_form']['type'] = 'composite';
$handler->display->display_options['exposed_form']['options']['reset_button'] = TRUE;
$handler->display->display_options['exposed_form']['options']['autosubmit'] = 0;
$handler->display->display_options['exposed_form']['options']['autosubmit_hide'] = 1;
$handler->display->display_options['exposed_form']['options']['plugins'] = array(
'basic' => 'basic',
'input_required' => 0,
'views_filters_selective' => 0,
);
$handler->display->display_options['exposed_form']['options']['input_required'] = array(
'text_input_required' => array(
'value' => 'Select any filter and click on Apply to see results',
'format' => 'code',
),
);
$handler->display->display_options['exposed_form']['options']['views_filters_selective'] = array(
'text_input_required' => array(
'value' => 'Select any filter and click on Apply to see results',
'format' => 'code',
),
'vfs' => array(
'page_text' => array(
'vfs_active' => 0,
'vfs_hide_empty' => 0,
),
'title' => array(
'vfs_active' => 0,
'vfs_hide_empty' => 0,
),
),
);
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '10';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['pager']['options']['id'] = '0';
$handler->display->display_options['pager']['options']['expose']['items_per_page_options_all'] = 0;
$handler->display->display_options['style_plugin'] = 'table';
$handler->display->display_options['style_options']['columns'] = array(
'id' => 'id',
'title' => 'title',
'raised_amount' => 'raised_amount',
);
$handler->display->display_options['style_options']['default'] = '-1';
$handler->display->display_options['style_options']['info'] = array(
'id' => array(
'sortable' => 0,
'default_sort_order' => 'asc',
'align' => '',
'separator' => '',
'empty_column' => 0,
),
'title' => array(
'sortable' => 0,
'default_sort_order' => 'asc',
'align' => '',
'separator' => '',
'empty_column' => 0,
),
'raised_amount' => array(
'sortable' => 0,
'default_sort_order' => 'asc',
'align' => '',
'separator' => '',
'empty_column' => 0,
),
);
$handler->display->display_options['style_options']['override'] = 1;
$handler->display->display_options['style_options']['sticky'] = 0;
$handler->display->display_options['style_options']['empty_table'] = 0;
/* Header: Global: Text area */
$handler->display->display_options['header']['area']['id'] = 'area';
$handler->display->display_options['header']['area']['table'] = 'views';
$handler->display->display_options['header']['area']['field'] = 'area';
$handler->display->display_options['header']['area']['empty'] = FALSE;
/* Field: CiviCRM Personal Campaign Pages: PCP ID */
$handler->display->display_options['fields']['id']['id'] = 'id';
$handler->display->display_options['fields']['id']['table'] = 'civicrm_pcp';
$handler->display->display_options['fields']['id']['field'] = 'id';
$handler->display->display_options['fields']['id']['label'] = '';
$handler->display->display_options['fields']['id']['exclude'] = TRUE;
$handler->display->display_options['fields']['id']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['id']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['id']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['id']['alter']['external'] = 0;
$handler->display->display_options['fields']['id']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['id']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['id']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['id']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['id']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['id']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['id']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['id']['alter']['trim'] = 0;
$handler->display->display_options['fields']['id']['alter']['html'] = 0;
$handler->display->display_options['fields']['id']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['id']['element_default_classes'] = 1;
$handler->display->display_options['fields']['id']['hide_empty'] = 0;
$handler->display->display_options['fields']['id']['empty_zero'] = 0;
$handler->display->display_options['fields']['id']['hide_alter_empty'] = 1;
$handler->display->display_options['fields']['id']['format_plural'] = 0;
/* Field: CiviCRM Personal Campaign Pages: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'civicrm_pcp';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = 'Team';
$handler->display->display_options['fields']['title']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['title']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['path'] = 'civicrm/pcp/info?reset=1&id=[id]';
$handler->display->display_options['fields']['title']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['title']['alter']['external'] = 0;
$handler->display->display_options['fields']['title']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['title']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['title']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim'] = 0;
$handler->display->display_options['fields']['title']['alter']['html'] = 0;
$handler->display->display_options['fields']['title']['element_label_colon'] = 1;
$handler->display->display_options['fields']['title']['element_default_classes'] = 1;
$handler->display->display_options['fields']['title']['hide_empty'] = 0;
$handler->display->display_options['fields']['title']['empty_zero'] = 0;
$handler->display->display_options['fields']['title']['hide_alter_empty'] = 1;
/* Field: CiviCRM Personal Campaign Pages: Amount Raised */
$handler->display->display_options['fields']['raised_amount']['id'] = 'raised_amount';
$handler->display->display_options['fields']['raised_amount']['table'] = 'civicrm_pcp';
$handler->display->display_options['fields']['raised_amount']['field'] = 'raised_amount';
$handler->display->display_options['fields']['raised_amount']['label'] = 'Amount raised';
$handler->display->display_options['fields']['raised_amount']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['external'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['word_boundary'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['ellipsis'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['trim'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['html'] = 0;
$handler->display->display_options['fields']['raised_amount']['element_label_colon'] = 0;
$handler->display->display_options['fields']['raised_amount']['element_default_classes'] = 0;
$handler->display->display_options['fields']['raised_amount']['hide_empty'] = 0;
$handler->display->display_options['fields']['raised_amount']['empty_zero'] = 0;
$handler->display->display_options['fields']['raised_amount']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['raised_amount']['set_precision'] = 0;
$handler->display->display_options['fields']['raised_amount']['precision'] = '';
$handler->display->display_options['fields']['raised_amount']['format_plural'] = 0;
$handler->display->display_options['fields']['raised_amount']['format_plural_singular'] = '';
$handler->display->display_options['fields']['raised_amount']['format_plural_plural'] = '';
$handler->display->display_options['fields']['raised_amount']['prefix'] = '$';
/* Sort criterion: CiviCRM Personal Campaign Pages: PCP ID */
$handler->display->display_options['sorts']['id']['id'] = 'id';
$handler->display->display_options['sorts']['id']['table'] = 'civicrm_pcp';
$handler->display->display_options['sorts']['id']['field'] = 'id';
$handler->display->display_options['sorts']['id']['order'] = 'DESC';
/* Contextual filter: CiviCRM Personal Campaign Pages: Page Status */
$handler->display->display_options['arguments']['status']['id'] = 'status';
$handler->display->display_options['arguments']['status']['table'] = 'civicrm_pcp';
$handler->display->display_options['arguments']['status']['field'] = 'status';
$handler->display->display_options['arguments']['status']['default_action'] = 'default';
$handler->display->display_options['arguments']['status']['default_argument_type'] = 'fixed';
$handler->display->display_options['arguments']['status']['default_argument_options']['argument'] = '2';
$handler->display->display_options['arguments']['status']['default_argument_skip_url'] = 0;
$handler->display->display_options['arguments']['status']['summary']['number_of_records'] = '0';
$handler->display->display_options['arguments']['status']['summary']['format'] = 'default_summary';
$handler->display->display_options['arguments']['status']['summary_options']['items_per_page'] = '25';
/* Filter criterion: CiviCRM Personal Campaign Pages: Intro text */
$handler->display->display_options['filters']['intro_text']['id'] = 'intro_text';
$handler->display->display_options['filters']['intro_text']['table'] = 'civicrm_pcp';
$handler->display->display_options['filters']['intro_text']['field'] = 'intro_text';
$handler->display->display_options['filters']['intro_text']['operator'] = 'contains';
$handler->display->display_options['filters']['intro_text']['exposed'] = TRUE;
$handler->display->display_options['filters']['intro_text']['expose']['operator_id'] = 'intro_text_op';
$handler->display->display_options['filters']['intro_text']['expose']['label'] = 'Team Members';
$handler->display->display_options['filters']['intro_text']['expose']['operator'] = 'intro_text_op';
$handler->display->display_options['filters']['intro_text']['expose']['identifier'] = 'intro_text';
$handler->display->display_options['filters']['intro_text']['expose']['required'] = 0;
$handler->display->display_options['filters']['intro_text']['expose']['multiple'] = FALSE;
/* Filter criterion: CiviCRM Personal Campaign Pages: Title */
$handler->display->display_options['filters']['title']['id'] = 'title';
$handler->display->display_options['filters']['title']['table'] = 'civicrm_pcp';
$handler->display->display_options['filters']['title']['field'] = 'title';
$handler->display->display_options['filters']['title']['operator'] = 'contains';
$handler->display->display_options['filters']['title']['exposed'] = TRUE;
$handler->display->display_options['filters']['title']['expose']['operator_id'] = 'title_op';
$handler->display->display_options['filters']['title']['expose']['label'] = 'Team name';
$handler->display->display_options['filters']['title']['expose']['operator'] = 'title_op';
$handler->display->display_options['filters']['title']['expose']['identifier'] = 'title';
$handler->display->display_options['filters']['title']['expose']['required'] = 0;
$handler->display->display_options['filters']['title']['expose']['multiple'] = FALSE;

/* Display: Page */
$handler = $view->new_display('page', 'Page', 'page');
$handler->display->display_options['defaults']['use_more'] = FALSE;
$handler->display->display_options['use_more_always'] = TRUE;
$handler->display->display_options['use_more_text'] = 'View more walkers to sponsor';
$handler->display->display_options['defaults']['pager'] = FALSE;
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '20';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['pager']['options']['id'] = '0';
$handler->display->display_options['pager']['options']['expose']['items_per_page_options_all'] = 0;
$handler->display->display_options['defaults']['header'] = FALSE;
/* Header: Global: Text area */
$handler->display->display_options['header']['area']['id'] = 'area';
$handler->display->display_options['header']['area']['table'] = 'views';
$handler->display->display_options['header']['area']['field'] = 'area';
$handler->display->display_options['header']['area']['empty'] = FALSE;
$handler->display->display_options['header']['area']['content'] = 'Below are our top fundraisers! Find the team or walker you’d like to sponsor by clicking on a name below or searching for another team.';
$handler->display->display_options['header']['area']['format'] = 'code';
$handler->display->display_options['header']['area']['tokenize'] = 0;
$handler->display->display_options['defaults']['fields'] = FALSE;
/* Field: CiviCRM Personal Campaign Pages: PCP ID */
$handler->display->display_options['fields']['id']['id'] = 'id';
$handler->display->display_options['fields']['id']['table'] = 'civicrm_pcp';
$handler->display->display_options['fields']['id']['field'] = 'id';
$handler->display->display_options['fields']['id']['label'] = '';
$handler->display->display_options['fields']['id']['exclude'] = TRUE;
$handler->display->display_options['fields']['id']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['id']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['id']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['id']['alter']['external'] = 0;
$handler->display->display_options['fields']['id']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['id']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['id']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['id']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['id']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['id']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['id']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['id']['alter']['trim'] = 0;
$handler->display->display_options['fields']['id']['alter']['html'] = 0;
$handler->display->display_options['fields']['id']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['id']['element_default_classes'] = 1;
$handler->display->display_options['fields']['id']['hide_empty'] = 0;
$handler->display->display_options['fields']['id']['empty_zero'] = 0;
$handler->display->display_options['fields']['id']['hide_alter_empty'] = 1;
$handler->display->display_options['fields']['id']['format_plural'] = 0;
/* Field: CiviCRM Personal Campaign Pages: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'civicrm_pcp';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = 'Team';
$handler->display->display_options['fields']['title']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['title']['alter']['make_link'] = 1;
$handler->display->display_options['fields']['title']['alter']['path'] = 'civicrm/pcp/info?reset=1&id=[id]';
$handler->display->display_options['fields']['title']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['title']['alter']['external'] = 0;
$handler->display->display_options['fields']['title']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['title']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['title']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim'] = 0;
$handler->display->display_options['fields']['title']['alter']['html'] = 0;
$handler->display->display_options['fields']['title']['element_label_colon'] = 1;
$handler->display->display_options['fields']['title']['element_default_classes'] = 1;
$handler->display->display_options['fields']['title']['hide_empty'] = 0;
$handler->display->display_options['fields']['title']['empty_zero'] = 0;
$handler->display->display_options['fields']['title']['hide_alter_empty'] = 1;
/* Field: CiviCRM Personal Campaign Pages: Amount Raised */
$handler->display->display_options['fields']['raised_amount']['id'] = 'raised_amount';
$handler->display->display_options['fields']['raised_amount']['table'] = 'civicrm_pcp';
$handler->display->display_options['fields']['raised_amount']['field'] = 'raised_amount';
$handler->display->display_options['fields']['raised_amount']['label'] = 'Amount raised';
$handler->display->display_options['fields']['raised_amount']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['external'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['word_boundary'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['ellipsis'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['trim'] = 0;
$handler->display->display_options['fields']['raised_amount']['alter']['html'] = 0;
$handler->display->display_options['fields']['raised_amount']['element_label_colon'] = 0;
$handler->display->display_options['fields']['raised_amount']['element_default_classes'] = 0;
$handler->display->display_options['fields']['raised_amount']['hide_empty'] = 0;
$handler->display->display_options['fields']['raised_amount']['empty_zero'] = 0;
$handler->display->display_options['fields']['raised_amount']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['raised_amount']['set_precision'] = 0;
$handler->display->display_options['fields']['raised_amount']['precision'] = '';
$handler->display->display_options['fields']['raised_amount']['format_plural'] = 0;
$handler->display->display_options['fields']['raised_amount']['format_plural_singular'] = '';
$handler->display->display_options['fields']['raised_amount']['format_plural_plural'] = '';
$handler->display->display_options['fields']['raised_amount']['prefix'] = '$';
$handler->display->display_options['path'] = 'sponsor-a-walker';

/* Display: Block */
$handler = $view->new_display('block', 'Block', 'block_1');
$handler->display->display_options['defaults']['use_more'] = FALSE;
$handler->display->display_options['use_more'] = TRUE;
$handler->display->display_options['use_more_always'] = TRUE;
$handler->display->display_options['use_more_text'] = 'Sponsor a walker';
$handler->display->display_options['defaults']['pager'] = FALSE;
$handler->display->display_options['pager']['type'] = 'some';
$handler->display->display_options['pager']['options']['items_per_page'] = '10';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['defaults']['header'] = FALSE;
$handler->display->display_options['defaults']['filters'] = FALSE;
/* Filter criterion: CiviCRM Personal Campaign Pages: Is Active */
$handler->display->display_options['filters']['is_active']['id'] = 'is_active';
$handler->display->display_options['filters']['is_active']['table'] = 'civicrm_pcp';
$handler->display->display_options['filters']['is_active']['field'] = 'is_active';
$handler->display->display_options['filters']['is_active']['value'] = '1';

This is my first posting for CiviCRM, so apologies in advance if I'm not posting in the right place...

I've got the same issue with displaying amount raised in version 3.4. Will/can this fix be applied to that version as well?

Thanks!

Quite possibly, take a look in the code, might be a different line number.

Sorry, I'm a bit unclear about exactly what was changed in the code. I can't dig into the source b/c it was applied to 4.2. Could you please provide some guidance.

thanks!

See the original post,

The views handler for raised_amount is incorrect.

Adding : 'float' => TRUE,

to line 1487 of civicrm.contribute.inc seems to fix things. Or if it's a different line number, just look for the views handler for raised_amount and add that line.

the only place where I can find a reference to the raised_amount field is in civicrm.views.inc...I don't see a civicrm.contribute.inc file anywhere in the module (in version 4.1.2).

the code I found in civicrm.views.inc is:

// amount raised
$data['civicrm_pcp']['raised_amount'] = array(
'title' => t('Amount Raised'),
'help' => t('Amount raised through this Personal Campaign Page'),
'real field' => id,
'field' => array(
'handler' => 'civicrm_handler_field_pcp_raised_amount',
'click sortable' => TRUE,
),
'argument' => array(
'handler' => 'views_handler_argument_numeric',
'numeric' => TRUE,
),
'filter' => array(
'handler' => 'views_handler_filter_numeric',
'allow empty' => TRUE,
),
'sort' => array(
'handler' => 'views_handler_sort',
),
);

I changed it to this but it had no effect on the formatting of the field in the view:

// amount raised
$data['civicrm_pcp']['raised_amount'] = array(
'title' => t('Amount Raised'),
'help' => t('Amount raised through this Personal Campaign Page'),
'real field' => id,
'field' => array(
'handler' => 'civicrm_handler_field_pcp_raised_amount',
'click sortable' => TRUE,
'float' => TRUE,
),
'argument' => array(
'handler' => 'views_handler_argument_numeric',
'numeric' => TRUE,
),
'filter' => array(
'handler' => 'views_handler_filter_numeric',
'allow empty' => TRUE,
),
'sort' => array(
'handler' => 'views_handler_sort',
),
);

I also tried this with no effect:

// amount raised
$data['civicrm_pcp']['raised_amount'] = array(
'title' => t('Amount Raised'),
'help' => t('Amount raised through this Personal Campaign Page'),
'real field' => id,
'field' => array(
'handler' => 'civicrm_handler_field_pcp_raised_amount',
'click sortable' => TRUE,
),
'argument' => array(
'handler' => 'views_handler_argument_numeric',
'numeric' => TRUE,
'float' => TRUE,
),
'filter' => array(
'handler' => 'views_handler_filter_numeric',
'allow empty' => TRUE,
),
'sort' => array(
'handler' => 'views_handler_sort',
),
);

Am I doing something wrong or does that fix not work with 4.1.2?

Thanks.