Details

    • Type: Sub-task
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: HR-1.2
    • Fix Version/s: HR-1.2
    • Component/s: Absence
    • Labels:
      None
    • Sprint:
      Sprint 1, Sprint 12b, Sprint 12d

      Description

      The "Absence Request" screen supports view and edit modes. Currently, the inbound link must be constructed based on the desired mode (eg "action=view" or "action=update"). This is not the desired behavior.

      The inbound link should always be the same (eg always "action=update" or always "action=view" – whichever is easier). Then:

      • If the current user has permission "administer CiviCRM", then use edit-mode.
      • If the activity status is unreviewed, then use edit-mode.
      • Otherwise, use view-mode.

      (Note: We may want to change the particular rules in the future - eg adding other conditions in which the activity may be edited.)

        Attachments

          Activity

          [HR-273] Dynamically select view or edit mode
          Nishant Bhorodia added a comment -

          Clicking on absence on absence list report with status = requested redirects to the view page where date fields are not populated and Total shows 0.

          Nishant Bhorodia added a comment -

          Query:

          If the user has permission "administer CiviCRM", would he be redirected to edit-mode regardless of the status of the absence ?

          Tim Otten added a comment -

          Yes, he should be. We apply some restrictions to regular users because of trust/incentive issues, but (as a general rule) every restriction needs some work-around – some way for users to bypass the restriction in weird cases. Allowing administrators to always edit records ensures that users (with a bit of discussion/coordination between the staffer and management) can fix weird cases.

            People

            • Assignee:
              Nishant Bhorodia
              Reporter:
              Tim Otten

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours
                6h