api.VolunteerNeed.getsearchresult needs refactoring

The server-side code for conducting this search is pretty inefficient. Searches don't scale well on very large sites.

Other refactoring has been discussed at length and should be reviewed before undertaking this effort. It would also be a useful exercised to trace through all the code (and all the entities) that gets touched in the course of a search.