Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-11026

Quick QA Pass on Accounts Branch Pre-merge

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.3.0
    • Component/s: Accounting Integration
    • Labels:
      None

      Description

      I switched to trunk.civiaccounts, ran setup.sh (which rebuilt DAOs and my DB and loaded generated.mysql sample data). Then did some very simple workflows. The following fatal errors occurred and s/b fixed prior to merge (unless something was wrong w/ my setup ???).
      =====================

      1. Try to add an offline contribution using default Financial Types and associated Financial Accounts. Selected "Donation" for financial type and I get this error on submit:

      Financial Account of account relationship of 'Is Asset Account of' is not configured for this Financial Type

      I don't know what this means or what to do about it (and in general the default sample data set should allow transactions like this w/o any additional configuration).

      2. Fatal error add back office event registration for sample Fall Fundraiser for an existing contact:
      #6 /Users/dgg/svn/crm_v4.3/packages/DB/mysql.php(898): DB_common->raiseError(-1, NULL, NULL, NULL, "1364 ** Field 'deductible_amount' doesn't have a default value")
      #7 /Users/dgg/svn/crm_v4.3/packages/DB/mysql.php(327): DB_mysql->mysqlRaiseError()
      #8 /Users/dgg/svn/crm_v4.3/packages/DB/common.php(1216): DB_mysql->simpleQuery("INSERT INTO civicrm_line_item (entity_table , entity_id , price_field_id , la...")
      #9 /Users/dgg/svn/crm_v4.3/packages/DB/DataObject.php(2421): DB_common->query("INSERT INTO civicrm_line_item (entity_table , entity_id , price_field_id , la...")
      #10 /Users/dgg/svn/crm_v4.3/packages/DB/DataObject.php(1055): DB_DataObject->_query("INSERT INTO civicrm_line_item (entity_table , entity_id , price_field_id , la...")
      #11 /Users/dgg/svn/crm_v4.3/CRM/Core/DAO.php(287): DB_DataObject->insert()
      #12 /Users/dgg/svn/crm_v4.3/CRM/Price/BAO/LineItem.php(65): CRM_Core_DAO->save()
      #13 /Users/dgg/svn/crm_v4.3/CRM/Event/Form/Participant.php(1508): CRM_Price_BAO_LineItem::create((Array:16))
      #14 /Users/dgg/svn/crm_v4.3/CRM/Core/Form.php(246): CRM_Event_Form_Participant->postProcess()
      #

      INSERT INTO civicrm_line_item (entity_table , entity_id , price_field_id , label , qty , unit_price , line_total , participant_count , price_field_value_id , financial_type_id ) VALUES ('civicrm_participant' , 51 , 8 , 'Couple' , 1 , 100 , 100 , 0 , 17 , 4 ) [nativecode=1364 ** Field 'deductible_amount' doesn't have a default value]

      NOTE: After fatal error, I was left with a contribution record with no linked participant or line item. Do we need a transaction here?

      3. Similar error adding back office membership w/ payment.

      4. Viewing a contribution record: User error: Smarty error: [in CRM/Custom/Page/CustomDataView.tpl line 185]: syntax error: unclosed tag {foreach} (opened line 28).

      5. Go to edit an existing (sample data) contribution:
      Notice: Trying to get property of non-object in buildQuickForm() (line 826 of /Users/dgg/svn/crm_v4.3/CRM/Contribute/Form/Contribution.php). =>
      • ... (Array, 13 elements)
      • Krumo version 0.2.1a
| http://krumo.sourceforge.net 
 Called from /Users/dgg/svn/crm_v4.3/CRM/Contribute/Form/Contribution.php, line 826  
      Warning: Invalid argument supplied for foreach() in buildQuickForm() (line 830 of /Users/dgg/svn/crm_v4.3/CRM/Contribute/Form/Contribution.php). =>
      • ... (Array, 13 elements)
      • Krumo version 0.2.1a
| http://krumo.sourceforge.net 
 Called from /Users/dgg/svn/crm_v4.3/CRM/Contribute/Form/Contribution.php, line 830  
      Notice: Undefined variable: LineTotal in buildQuickForm() (line 849 of /Users/dgg/svn/crm_v4.3/CRM/Contribute/Form/Contribution.php). =>
      • ... (Array, 13 elements)
      • Krumo version 0.2.1a
| http://krumo.sourceforge.net 
 Called from /Users/dgg/svn/crm_v4.3/CRM/Contribute/Form/Contribution.php, line 849  
      Warning: strlen() expects parameter 1 to be string, array given in strlen() (line 138 of /Users/dgg/svn/crm_v4.3/packages/HTML/QuickForm/checkbox.php). =>

      5. Add contact via Quick Add form block. Fatal error:
      Parse error: syntax error, unexpected T_FUNCTION, expecting T_PAAMAYIM_NEKUDOTAYIM in /Users/dgg/svn/crm_v4.3/CRM/Contact/Form/Edit/Individual.php on line 132
      Call Stack
      #
      Time
      Memory
      Function
      Location
      1
      0.0001
      662208

      {main}

      ( )
      ../index.php:0
      2
      0.4359
      31732192
      menu_execute_active_handler( )
      ../index.php:21
      3
      0.4360
      31733392
      call_user_func_array ( )
      ../menu.inc:516
      4
      0.4360
      31734008
      civicrm_invoke( )
      ../menu.inc:516
      5
      0.6071
      43831832
      CRM_Core_Invoke::invoke( )
      ../civicrm.module:464
      6
      0.6346
      46012056
      CRM_Utils_Wrapper->run( )
      ../Invoke.php:192
      7
      0.7155
      50346048
      CRM_Core_Controller->run( )
      ../Wrapper.php:115
      8
      0.7157
      50354032
      HTML_QuickForm_Page->handle( )
      ../Controller.php:289
      9
      0.7158
      50354112
      HTML_QuickForm_Controller->handle( )
      ../Page.php:103
      10
      0.7158
      50354112
      CRM_Core_QuickForm_Action_Next->perform( )
      ../Controller.php:203
      11
      0.7158
      50354328
      CRM_Core_StateMachine->perform( )
      ../Next.php:60
      12
      0.7158
      50354408
      CRM_Core_Form->buildForm( )
      ../StateMachine.php:135
      13
      0.7399
      53397296
      CRM_Contact_Form_Contact->buildQuickForm( )
      ../Form.php:350
      14
      0.7399
      53400040
      eval( 'CRM_Contact_Form_Edit_Individual::buildQuickForm( $this, $this->_action );' )
      ../Contact.php:755
      15
      0.7399
      53400672
      CRM_Core_ClassLoader->loadClass( )
      ../Contact.php:0

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                pradeep.nayak Pradeep Nayak
                Reporter:
                dgg David Greenberg
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: