Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-7443 Improve E_WARNING compliance.
  3. CRM-7678

Ensure that sort key is set for all getColumnHeaders() functions.

    Details

    • Type: Sub-task
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.0, 4.0.0, 4.1.0, Unscheduled
    • Fix Version/s: 4.2.0
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      As an alternative to editing dozens of templates to check for !empty($header.sort), the sort keys should probably be set for all headers returned by getColumnHeaders.

      ~$ diffstat getColumnHeaders.sort.patch
      Campaign/Selector/Search.php | 12 ++++++++----
      Case/Selector/Search.php | 8 ++++++--
      Contact/Selector.php | 6 +++---
      Core/Selector/API.php | 10 ++++++++--
      Grant/Selector/Search.php | 4 +++-
      Mailing/Page/Browse.php | 3 +++
      Mailing/Selector/Browse.php | 3 ++-
      Mailing/Selector/Event.php | 5 +++++
      Member/Selector/Search.php | 1 +
      Profile/Selector/Listings.php | 2 +-
      10 files changed, 40 insertions, 14 deletions

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              pillarsdotnet Bob Vincent
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: