Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-7443 Improve E_WARNING compliance.
  3. CRM-7691

Allow templates/CRM/Case/Form/ActivityToCase.tpl to tolerate an unassigned buildCaseActivityForm or fulltext variable.

    Details

    • Type: Sub-task
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.0, 4.0.0, 4.1.0, Unscheduled
    • Fix Version/s: 4.1.0
    • Component/s: CiviCase
    • Labels:
      None

      Description

      Allow templates/CRM/Case/Form/ActivityToCase.tpl to tolerate an unassigned buildCaseActivityForm variable. The converse fix, making sure that the variables always get assigned, would require patching at least six other source code files.

      diff --git templates/CRM/Case/Form/ActivityToCase.tpl templates/CRM/Case/Form/ActivityToCase.tpl
      index ef6fd7a..277b578 100644
      — templates/CRM/Case/Form/ActivityToCase.tpl
      +++ templates/CRM/Case/Form/ActivityToCase.tpl
      @@ -26,7 +26,7 @@
      {* CiviCase - build activity to a case*}
      <div id="fileOnCaseDialog"></div>

      -

      {if $buildCaseActivityForm}

      +

      {if !empty($buildCaseActivityForm)}

      <div class="crm-block crm-form-block crm-case-activitytocase-form-block">
      <table class="form-layout">
      <tr class="crm-case-activitytocase-form-block-unclosed_cases">
      @@ -149,7 +149,7 @@ function fileOnCase( action, activityID, currentCaseId ) {
      } else {
      var destUrl =

      {/literal}"{crmURL p='civicrm/contact/view/case' q='reset=1&action=view&id=' h=0 }"{literal};
      var context = '';
      - {/literal} {if $fulltext} {literal}
      + {/literal}{if !empty($fulltext)}{literal}

      context = '&context=

      {/literal}{$fulltext}{literal}';
      {/literal} {/if} {literal}


      var caseUrl = destUrl + selectedCaseId + '&cid=' + contactId + context;

        Attachments

          Activity

            People

            • Assignee:
              rajan Rajan P Mayekar
              Reporter:
              pillarsdotnet Bob Vincent
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: