Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Minor
-
Resolution: Duplicate
-
Affects Version/s: 3.4.1, 4.0.1
-
Component/s: Core CiviCRM
-
Labels:None
Description
If you try to create a new front-end menu fo:
CiviCRM :: Personal Campaign Pages
CiviCRM :: Personal Campaign Information Pages
You get various errors in the Basic Options block (depending on j1.6 or j1.5 and which menu type:
J 1.5 : Warning: Invalid argument supplied for foreach() in /var/www/joomla.demo.civicrm.org/public/libraries/joomla/html/html/select.php on line 68
J 1.6 : Warning: Invalid argument supplied for foreach() in /var/www/j16.sandbox.civicrm.org/public/libraries/joomla/html/html/select.php on line 509
Ideally when we fix this we should also check and fix the behavior for each of these when there are no eligible Contribution Pages (w/ PCP enabled) - item 1; and when there are no viewable PCP's (item 2)
As a side note, I think we should change the layout title, name and description for these to be a bit clearer.
For php.xml:
<layout title="Personal Campaign Page - Create" >
<name>Personal Campaign Page - Create</name>
<description>Link to create a new CiviCRM Personal Campaign Page</description>
For phpinfo.xml:
<layout title="Personal Campaign Page - View" >
<name>Personal Campaign Page - View</name>
<description>Link to view an existing CiviCRM Personal Campaign Page</description>
Attachments
Issue Links
- is duplicated by
-
-
- Done/Fixed
-
Activity
Dave,
As I understand from looking at 3.4/1.5 the problem is that if there are no phps enabled the link to specific pages can't be made, is that right? Other than that i'm not seeing a problem. I think we should just prevent a menu item from being created in that case. Is that the issue or are you seeing something else?
Also I notice that you can make links to contributrion pages without a from email being set and this creates a nasty error display to site vistors. It's reall a separate issue but we might want to check that too.
Corrected PCP elements for v4
Use this for v4 instead (ignore first file).
For 3.4
There seem to be a number of separate issues going on but the attached changes to the php elements files should address the most immediate issues of not being able to make menu links at all and of problems in the front end. Also I added a "select xxx" to the option lists in the form so at least they aren't blank. I do agree with Dave that we might prefer to conditionally add some text saying that you must have at least one in order to make a menu item. Also we could in 1.6 for sure add required="true" to the xml but that will only check on validation not prevent an attempt to save.
Duplicate of CRM-8239.
Elin - feel free to ping me if you have questions etc. on this. Thx!